vsgcameras demo of viewport partially off screen #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overlay views are partially off the screen. The initial rendering is good, but the model snaps to the scissors of the overlays when the window is resized. This is because the viewport gets set to the scissor in the viewportstate. It was expected that the viewport and the scissor remain independent and should be resized individually.
Collaborator
|
For testing purpose I have merged this PR as a branch: https://github.com/vsg-dev/vsgExamples/tree/theodoregoetz-vewport-partially-offscreen On resize 'vsgcameras models/teapot.vsgt' resets the viewports to the extents of the window, which from the description of the issue is the problem that needs resolving. There is also a bug in the management of the aspect ratio of the secondary views, this is a separate issue which occurs with vsgExamples master. I will be looking at both issues. |
Collaborator
|
I have merged a refactor of WindowResizeHandler into VSG master that handles this usage case so that the modified vsgcameras example now works sensible: I'm going to close this PR as I believe it's no longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstration only!!! Do not merge to master.
This was tested against the dynamic-viewports3 branch in VulkanSceneGraph, commit: 1fac1761
The overlay views are partially off the screen. The initial rendering is good, but the model snaps to the scissors of the overlays when the window is resized. This is because the viewport gets set to the scissor in the viewportstate. It was expected that the viewport and the scissor remain independent and should be resized individually.
initial view (expected):
view after a window resize (the models should not be snapped to the scissors of the overlay views):