Skip to content

Conversation

@theodoregoetz
Copy link
Contributor

@theodoregoetz theodoregoetz commented Jun 4, 2025

added pNext allocInfo for createBufferAndMemory()
so that we can customize the memory allocation, specifically for raytracing.
This resolves vulkan validation errors when creating memory with the
device address usage bit but without the bit set in the pNext structure.

Note that this PR includes changes found in #1439 and essentially takes it one step further.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • no doc needed - this just follows from the memory allocation Vulkan API

How Has This Been Tested?

This was tested on our own raytracing example code. Was shown to work on linux windows and mac (arm).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (raytracing example in the vsgExamples should suffice)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules (Not relevant)

This resolves vulkan validation errors when creating memory with the
device address usage bit but without the bit set in the pNext structure.
@robertosfield robertosfield merged commit fa47971 into vsg-dev:master Jun 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants