Skip to content

Conversation

@AnyOldName3
Copy link
Contributor

Fixes CI for forks by:

  • Switching to a version of the Vulkan SDK that's still available.
  • Switching to a version (which hasn't made it to a release yet) of install-vulkan-sdk that can handle slightly newer Vulkan SDK packages.

It doesn't switch to the latest release as no version of install-vulkan-sdk can deal with it yet.

The previously-used version is no longer available so CI fails for committers who don't already have it cached in their fork.

We can't bump the version more than this as the archive formats were
switched and humbletim/install-vulkan-sdk can't handle that yet.
The latest release can't handle newer MacOS builds.
@robertosfield
Copy link
Collaborator

I have merged this PR as a branch and will see what happens with the automated build:

https://github.com/vsg-dev/VulkanSceneGraph/tree/AnyOldName3-bump-ci-vulkan-sdk

@robertosfield
Copy link
Collaborator

@AnyOldName3 automated build has run cleanly, is there any more testing we need to do before I merged with VSG master?

@AnyOldName3
Copy link
Contributor Author

It's not exactly more testing, as it's already happened, but here's a CI run on my fork from the gamma correctness branch which failed due to not having these commits https://github.com/AnyOldName3/VulkanSceneGraph/actions/runs/11332586516/job/31515009697 and one from this branch that now works https://github.com/AnyOldName3/VulkanSceneGraph/actions/runs/11350773480/job/31569912536

@robertosfield
Copy link
Collaborator

So go ahead and merge with VSG master?

@AnyOldName3
Copy link
Contributor Author

Yeah, I think it's ready.

@robertosfield robertosfield merged commit 1781594 into vsg-dev:master Oct 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants