Ensure minimum maxSets is at least one #1203
Conversation
Following the discussions in vsg-dev#960 and vsg-dev#961 this sets the minimum maxSets to 1 so that when switching out graphics pipelines that use different descriptor sets, the warning about Context::reserve() is avoided
|
I am busy with rewriting vsg::Allocator right now, and have client work backed up so can't look into the topic in detail right away. This topic that I will look at before 1.2, it may be that I need to rewrite the DescriptorPool management. |
|
I am now testing/reviewing the bug, I have test case that recreates it reliably so will use that for testing. As part of the testing/reviewing process I have merged this PR as a branch: I haven't yet looked into the bug and the associated code enough to know what the correct fix will be, hopefully I'll have this resolved in the next day or so and will then make another developer release for it. |
|
Running my test against this PR it does at least quieten the console warning, at least that's confirmed, can't say whether it's just hiding an issue or resolve it yet though. |
|
I'm now quite advanced with a refactor of how vsg::DescriptorPool are managed with the introduction of new vsg::DescriptorPools class. The implementation should already address the issues tackled by this PR so should make this PR redudent. Could you please test the DescriptorPool branch of the VSG to check that things are working correctly for you application? Thanks. |
|
Hi Robert,
I tested the DescriptorPool branch on both Kubuntu and Windows and both
worked fine. Only the Kubuntu version was running with the debug layer and
there were no messages. Looks good to me!
Regards,
Roland
…On Wed, 17 Jul 2024 at 04:03, Robert Osfield ***@***.***> wrote:
I'm now quite advanced with a refactor of how vsg::DescriptorPool are
managed with the introduction of new vsg::DescriptorPools class. The
implementation should already address the issues tackled by this PR so
should make this PR redudent. Could you please test the DescriptorPool
<https://github.com/vsg-dev/VulkanSceneGraph/tree/DescriptorPool>branch
of the VSG to check that things are working correctly for you application?
Thanks.
—
Reply to this email directly, view it on GitHub
<#1203 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPOEQ5QUB3LQSKXCJN5WW3ZMVN5HAVCNFSM6AAAAABIPLTOVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGUYDKNRYHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I have now completed my work on vsg::DescriptorPools and have merged it with VSG master with the PR #1239. I will now close this PR as it should no longer be required. |
3 participants
Following the discussions in #960 and #961 this sets the minimum maxSets to 1 so that when switching out graphics pipelines that use different descriptor sets, the warning about Context::reserve() is avoided. See also
See issues:
And in vsgExamples:
This PR is a possible fix for the warning, but it's unclear to this author if this is the correct and robust solution. I expect a discussion on the merits of this w.r.t. other possible changes to follow here or in the discussion board.