Skip to content

Added ability to specify the lightDataSize in the fragment shader via specialization consistent with id=3 #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Added ability to specify the lightDataSize in the fragment shader via specialization consistent with id=3 #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba12357
Added debug ouptu of lightDataSize
robertosfield Apr 22, 2024
6d4ed94
Updated built-in ShaderSets
robertosfield Apr 22, 2024
855626d
Remvoed debug output, and refine comment to explan lightDataSize
robertosfield Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/vsg/state/ViewDependentState.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ void ViewDependentState::init(ResourceRequirements& requirements)
maxShadowMaps = 0;
}

uint32_t lightDataSize = 4 + maxNumberLights * 16 + maxShadowMaps * 16;
// 1 vec3 is used for specifying the number of lights, lagest lightData entries are for spot light with 4 vec4s per light, and each shadowmap takes 8 vec4s.
uint32_t lightDataSize = 1 + maxNumberLights * 4 + maxShadowMaps * 8;

#if 0
if (active)
Expand Down
Loading