Create OpenStax Accounts provider #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bnfinet
added a commit
that referenced
this pull request
Sep 13, 2019
bnfinet
added a commit
that referenced
this pull request
May 22, 2020
bnfinet
added a commit
that referenced
this pull request
May 22, 2020
Create OpenStax Accounts provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a oauth2 provider (OpenStax Accounts: https://github.com/openstax/accounts) that is almost an openid provider. With a couple small tweaks, I can authenticate against it. The primary
problem is the lack of an
id_tokenin the return from thetokenendpoint. Secondarily, the userinfo is only accidentally matching to OpenId userinfo - create some mappings like the other cases in the code.Not sure how to generalize either of those things, to be honest.
This PR also contains the cleanups from my previous PR: If you want to commit them separately, I'll rebase this one.