workaround for missing cvss v2 section #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current definition of "string" doesn't work out. I understand that there currently is no v2 definition available, however if a v2 section is present, now it will fail to parse the file as a "string" is expected but a "map" is found.
Owner
|
Thanks - this makes sense. The upstream CVSS crate only provides a V2 data model, but we should still parse v2. I did not have any documents with V2 values in the test set. I'll merge this and add a case to catch regressions. Adding an actual data model for V2 is a 'TODO'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes #9 to fix the build.
fix: represent the CVSS v2 section as "any JSON"
The current definition of "string" doesn't work out. I understand that there currently is no v2 definition available, however if a v2 section is present, now it will fail to parse the file as a "string" is expected but a "map" is found.