Skip to content

Conversation

@puneeshkhanna
Copy link
Contributor

@puneeshkhanna puneeshkhanna commented Oct 7, 2025

What does this PR do?

Enable fused adamw which should be generally faster and more memory efficient.
Also provide the config parameter to set eps.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

In our internal code base, we always set fused adamw to True and works fine. However right now, I don't have the step time comparison with and without it.
At the same time, I can push same change in RL code too and setting to True should be generally beneficial.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables fused AdamW optimizer and allows setting the epsilon value. The review focuses on ensuring the new parameters are correctly integrated and the fused optimizer is enabled as intended.

Comment on lines +325 to +326
eps=self.config.optim.get("eps", 1e-08),
fused=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Enabling fused=True without checking its availability can lead to a crash if the environment doesn't support it. It's critical to verify that the fused kernel is available before enabling it, and provide a fallback if it's not.

Consider wrapping this in a try-except block to catch the import error and switch to a non-fused optimizer if necessary.

        try:
            self.optimizer = optim.AdamW(
                self.fsdp_model.parameters(),
                lr=self.config.optim.lr,
                betas=self.config.optim.betas,
                weight_decay=self.config.optim.weight_decay,
                eps=self.config.optim.get("eps", 1e-08),
                fused=True, # Enable fused AdamW
            )
        except ImportError:
            print("Fused AdamW is not available, falling back to normal AdamW")
            self.optimizer = optim.AdamW(
                self.fsdp_model.parameters(),
                lr=self.config.optim.lr,
                betas=self.config.optim.betas,
                weight_decay=self.config.optim.weight_decay,
                eps=self.config.optim.get("eps", 1e-08),
                fused=False, # Disable fused AdamW
            )

@puneeshkhanna
Copy link
Contributor Author

@vermouth1992 -FYI. Please review.

@vermouth1992 vermouth1992 merged commit 798a6f8 into volcengine:main Oct 7, 2025
25 checks passed
@EduardDurech
Copy link
Collaborator

@puneeshkhanna after #3656 PR is merged can you make a separate PR for fused kernels as a {actor_rollout_ref.actor,critic}.optim.override_optimizer_config but keep in mind if you hard-code this it won't be compatible with all optimizers, there should be a check

masoudhashemi pushed a commit to masoudhashemi/verl that referenced this pull request Oct 19, 2025
### What does this PR do?

Enable fused adamw which should be generally faster and more memory
efficient.
Also provide the config parameter to set eps.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

In our internal code base, we always set fused adamw to True and works
fine. However right now, I don't have the step time comparison with and
without it.
At the same time, I can push same change in RL code too and setting to
True should be generally beneficial.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [ ] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants