Skip to content

[misc] fix: Allow HF model ID with use_shm #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[misc] fix: Allow HF model ID with use_shm #3663

wants to merge 2 commits into from
+14 −1

Conversation

EduardDurech
Copy link
Collaborator

No description provided.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to allow using Hugging Face model IDs with use_shm. The implementation correctly adds logic to download models from the Hub. However, I've found a critical issue where this logic is incorrectly tied to the use_shm flag, causing it to fail when use_shm is false. Additionally, the error handling is too broad and silences all exceptions, which will make debugging difficult. I've provided suggestions to fix these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EduardDurech