Skip to content

Conversation

HJSang
Copy link
Contributor

@HJSang HJSang commented Oct 2, 2025

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

The problem is in the get_tool_call_parser_type function in sglang_rollout.py (lines 225-246). The function is checking if parser.bot_token.strip() exists as a single token in the tokenizer's vocabulary, but for the gpt-oss parser type, the bot_token is <|start|>assistant<|channel|>commentary, which is a compound token sequence rather than a single special token. For gpt-oss models,

parser.bot_token.strip() = <|start|>assistant<|channel|>commentary
This gets tokenized as [200006, 173781, 200005, 12606, 815] (5 tokens)

The check parser.bot_token.strip() in tokenizer_vocab returns False because it's looking for this entire string as a single vocabulary entry
The current logic assumes that bot_token should be a single special token that exists in the vocabulary, but for GPT-OSS models, it's actually a sequence of tokens that need to be tokenized.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

unit test offline

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in get_tool_call_parser_type for gpt-oss models, where the tool call parser was not correctly identified due to its multi-token bot_token. The fix introduces a special check for gpt-oss models based on their name_or_path. While this is a pragmatic solution, my review highlights the maintainability concerns of this hardcoded approach and suggests improvements to the logging.

@HJSang HJSang changed the title fix get_tool_call_parser_type for gpt-oss models fix get_tool_call_parser_type for gpt-oss models in sglang rollout Oct 4, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@wuxibin89 wuxibin89 changed the title fix get_tool_call_parser_type for gpt-oss models in sglang rollout [rollout,sglang] fix: get_tool_call_parser_type for gpt-oss models in sglang rollout Oct 9, 2025
@wuxibin89 wuxibin89 merged commit d45d049 into volcengine:main Oct 9, 2025
47 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants