Skip to content

Conversation

kfallah
Copy link
Contributor

@kfallah kfallah commented Sep 27, 2025

What does this PR do?

Currently, async vLLM with AgentWorkerLoop throws an error when update_weights with LoRA weights. This expands support for AgentWorkerLoop with LoRAs.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@kfallah kfallah marked this pull request as ready for review September 27, 2025 22:47
@wuxibin89 wuxibin89 changed the title [async vllm] Fix: Add LoRA Loading to Async vLLM [rollout,vllm] fix: Add LoRA Loading to Async vLLM Sep 28, 2025
@wuxibin89 wuxibin89 merged commit 39e531f into volcengine:main Sep 28, 2025
47 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants