[vLLM]feat: support micro batch for vllm #1818
Closed
+304
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhaiq
reviewed
Jun 3, 2025
| exceptoin: Exception | ||
|
|
||
|
|
||
| class MicroBatchChatCompletionScheduler(NaiveChatCompletionScheduler): |
There was a problem hiding this comment.
NaiveChatCompletionScheduler 的定位应该只是个demo，所以放在example里面。你写的这个应该是正式的版本，挪到 verl/workers/rollout/ 这个目录，直接从ChatCompletionScheduler继承比较合适。
然后把MicroBatchChatCompletionScheduler设置成默认的scheduler
chenhaiq
reviewed
Jun 3, 2025
| self.max_inflight_req = max_inflight_req | ||
| self.server_addresses = server_addresses | ||
| self.proxy_agents_coros = self._init_proxy_group(self.server_addresses, self.send_queue, self.reduce_queue, self.max_inflight_req) | ||
| print(self.proxy_agents_coros) |
There was a problem hiding this comment.
有很多print，如果对训练没帮助就删了吧。如果需要，改成logger
chenhaiq
reviewed
Jun 3, 2025
|
|
||
|
|
||
| class MicroBatchChatCompletionScheduler(NaiveChatCompletionScheduler): | ||
| def __init__(self, config, model_path, server_addresses, max_cache_size=10000, max_inflight_req=8): |
There was a problem hiding this comment.
在配置文件里面，给 max_inflight_req 加个配置，并写一下使用说明
| if exception is not None: | ||
| print("[MicroBatchChatCompletionScheduler] _consumer process callback get exception", idx) | ||
| await reduce_queue.put(RolloutSample(completions, info, None, None, None, exceptoin=exception)) | ||
| else: |
There was a problem hiding this comment.
这里的if else分支没起作用吧？
await reduce_queue.put(RolloutSample(completions, info, None, None, None, exceptoin=exception) 是不是就行了
| semaphore = asyncio.Semaphore(max_inflight_req) | ||
| local_queue = asyncio.Queue(max_inflight_req) | ||
| coros.append(self.get_element(addr, send_queue, local_queue, semaphore)) | ||
| coros.extend([self.process(local_queue, reduce_queue, semaphore, addr, i) for i in range(max_inflight_req)]) |
There was a problem hiding this comment.
因为对每个 sample都要取semaphore，那么max_inflight_req是不是并没有起到作用？
12 tasks
13 tasks
|
A PR feature without description and usage example is not acceptable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.