Actions: Add new workflow for generating windows EXEs with pyinstaller #1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgoodwine
commented
Jan 14, 2025
cgoodwine
commented
- This PR provides an alternative to Actions: Add section for building windows exe #1111 for generating pyinstaller executables for Windows via GithHub actions. The main difference is that this version uses a new GitHub workflow file for clearer separation.
- If this looks good, I can submit a separate PR that adds some basic testing to the generated pyinstallers
|
This looks cleaner to me, thanks @cgoodwine. |
ikelos
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.