Skip to content

Refactor: move version None check to top #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

Refactor: move version None check to top #1402

merged 1 commit into from
Dec 16, 2024

Conversation

TheMythologist
Copy link
Contributor

Otherwise, this will cause an error when generating the default description in the if description is None branch:

TypeError: 'NoneType' object is not iterable

ikelos
ikelos approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@ikelos ikelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks! 5:)

@ikelos ikelos merged commit 793039b into volatilityfoundation:develop Dec 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikelos ikelos ikelos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMythologist @ikelos