Skip to content

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Sep 25, 2021

Nbconvert 6.2 adds an argument to the jupyter_widgets macro.

Overriding this in voilà with the old number of arguments breaks calling it from the base nbconvert templates with the higher number of args.

Cf jupyter/nbconvert#1607 (comment)

@github-actions
Copy link
Contributor

Binder 👈 Try it on binder (branch SylvainCorlay/voila/update-to-nbconvert-6.2)

@SylvainCorlay
Copy link
Member Author

The visual regression test failure appears to be a 1-px shift due to the ipympl release.

@SylvainCorlay SylvainCorlay merged commit ef10b82 into voila-dashboards:main Sep 25, 2021
@SylvainCorlay SylvainCorlay deleted the update-to-nbconvert-6.2 branch September 25, 2021 11:15
@jtpio jtpio added this to the 0.2.x milestone Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants