Skip to content

Conversation

SylvainCorlay
Copy link
Member

@jtpio
Copy link
Member

jtpio commented Aug 27, 2021

Thanks!

@jtpio jtpio added the enhancement New feature or request label Aug 27, 2021
@jtpio jtpio added this to the 0.3.0 milestone Sep 1, 2021
@jtpio jtpio marked this pull request as draft September 1, 2021 09:37
@jtpio
Copy link
Member

jtpio commented Sep 1, 2021

Converting to draft for now so we can get a new 0.2.x release out, before targeting 0.3.0 on master.

@jtpio
Copy link
Member

jtpio commented Sep 1, 2021

Rebased to pick up the CI fix from #934

@jtpio
Copy link
Member

jtpio commented Oct 15, 2021

Is that something we would still like to get in for 0.3.0? #991

@jtpio
Copy link
Member

jtpio commented Oct 15, 2021

Rebased onto the latest main

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb
Render
chromium
actual 3215 <- [3232 - 3327 - 3490] -> 3742 2870 <- [3060 - 3122 - 3184] -> 3187 3143 <- [3457 - 3557 - 3608] -> 3781 4141 <- [4180 - 4270 - 4352] -> 4510 2342 <- [2349 - 2370 - 2370] -> 2391 3903 <- [3927 - 4038 - 4132] -> 4293 10470 <- [16011 - 18180 - 18722] -> 18807 13966 <- [13967 - 14093 - 14223] -> 14282 1217 <- [1529 - 1609 - 1647] -> 1693
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2021-10-27 14:31:31.456608474 +0000
+++ /dev/fd/62	2021-10-27 14:31:31.456608474 +0000
@@ -8,33 +8,33 @@
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v4",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
         "l2": 524288,
-        "l3": 52428800
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "79",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.3,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "1",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7291695104
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.8.0-1042-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "f9921186bd234a19abbbb6b3668b2567",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc
Copy link
Member

Hello, is this PR ready for review?

@jtpio
Copy link
Member

jtpio commented Oct 27, 2021

I would say yes.

Maybe we can also bring the example notebook here if the voila-reveal repo is going to be archived in the future: https://github.com/voila-dashboards/voila-reveal/blob/master/notebooks/reveal.ipynb

@trungleduc trungleduc marked this pull request as ready for review October 27, 2021 14:22
@jtpio
Copy link
Member

jtpio commented Oct 27, 2021

@jtpio
Copy link
Member

jtpio commented Oct 27, 2021

Looking good:

image

@trungleduc
Copy link
Member

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move voila-reveal to core voila
3 participants