Skip to content

Send kernel shutdown request manually on beforeunload #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Send kernel shutdown request manually on beforeunload #612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e6d98c
Send kernel shutdown request manually on beforeunload
jtpio May 20, 2020
074618f
Send X-XSRFToken header
jtpio May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion share/jupyter/voila/templates/base/static/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,13 @@ require([window.voila_js_url || 'static/voila'], function(voila) {

async function init() {
// it seems if we attach this to early, it will not be called
const matches = document.cookie.match('\\b_xsrf=([^;]*)\\b');
const xsrfToken = (matches && matches[1]) || '';
window.addEventListener('beforeunload', function (e) {
kernel.shutdown();
const xhttp = new XMLHttpRequest();
xhttp.open("DELETE", `/api/kernels/${kernel.id}`, false);
xhttp.setRequestHeader('X-XSRFToken', xsrfToken);
xhttp.send();
kernel.dispose();
});
await widgetManager.build_widgets();
Expand Down