Skip to content

Server extension: Fix merging with local config #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

Server extension: Fix merging with local config #1543

merged 1 commit into from
Aug 25, 2025

Conversation

martinRenou
Copy link
Member

Fixing #1538

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/fix_merging_configs

@martinRenou martinRenou added the bug Something isn't working label Aug 25, 2025
@jtpio
Copy link
Member

jtpio commented Aug 25, 2025

Thanks!

Ideally it would be great to have tests for this. But maybe it could be tracked in an issue if there is none currently and may take a while to add.

@martinRenou
Copy link
Member Author

Agreed! Let's make a hot fix release and track that in an issue

@martinRenou martinRenou merged commit 86dbefc into voila-dashboards:main Aug 25, 2025
33 of 35 checks passed
@martinRenou martinRenou deleted the fix_merging_configs branch August 25, 2025 13:43
@jtpio jtpio mentioned this pull request Aug 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

@jtpio jtpio Awaiting requested review from jtpio

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @jtpio @trungleduc