Skip to content

Add support for es modules, fixes #1413 #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add support for es modules, fixes #1413 #1414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97b47fa
Add support for es modules, fixes #1413
timkpaine Oct 31, 2023
a4b359a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions voila/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,11 @@ def include_css(template_name: str, base_url: str, name: str) -> str:
return Markup(code)


def include_js(template_name: str, base_url: str, name: str) -> str:
code = f'<script src="{make_url(template_name, base_url, name)}"></script>'
def include_js(
template_name: str, base_url: str, name: str, module: bool = False
) -> str:
type = 'type="module"' if module else ""
code = f'<script src="{make_url(template_name, base_url, name)}" {type}></script>'
return Markup(code)


Expand Down