Skip to content

Simplify some code #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Simplify some code #1329

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90a591e
Use partial
davidbrochart Jun 15, 2023
3e2d108
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 15, 2023
75a8b21
Remove unneeded inner_cell_generator function
davidbrochart Jun 15, 2023
f730ed7
Change comments a bit
davidbrochart Jun 15, 2023
30b7e70
Merge branch 'main' into partial
martinRenou Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions voila/notebook_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import os
import sys
import traceback
from functools import partial
from typing import Generator, List, Tuple, Union

import nbformat
Expand Down Expand Up @@ -150,8 +151,7 @@ def generate_content_generator(
kernel_id: Union[str, None] = None,
kernel_future=None,
) -> Generator:
async def inner_kernel_start(nb):
return await self._jinja_kernel_start(nb, kernel_id, kernel_future)
inner_kernel_start = partial(self._jinja_kernel_start, kernel_id=kernel_id, kernel_future=kernel_future)

def inner_cell_generator(nb, kernel_id):
return self._jinja_cell_generator(nb, kernel_id)
Expand Down