Skip to content

Conversation

martinRenou
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/update_check_release

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 85 <- [89 - 99 - 112] -> 153 79 <- [85 - 92 - 105] -> 136 78 <- [82 - 90 - 98] -> 117 73 <- [76 - 83 - 94] -> 123 3063 <- [3112 - 3161 - 3283] -> 4100 2727 <- [2743 - 2821 - 2908] -> 2994 3037 <- [3087 - 3239 - 3298] -> 3583 3042 <- [3135 - 3200 - 3386] -> 3449 2516 <- [2554 - 2671 - 2700] -> 2713 4424 <- [4464 - 4618 - 4893] -> 5984 4991 <- [5022 - 5098 - 5179] -> 5245 2032 <- [2068 - 2091 - 2123] -> 2297 14640 <- [17506 - 22395 - 31928] -> 60313
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2023-02-21 15:44:26.591527143 +0000
+++ /dev/fd/62	2023-02-21 15:44:26.591527143 +0000
@@ -4,49 +4,49 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8171M",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "4",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281274880
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
       "build": "",
-      "codename": "Jammy Jellyfish",
+      "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1033-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "22.04.1 LTS",
-      "serial": "59f3cd57c4494a3389d07bf76fa9750d",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

"check-wheel-contents",
]

[tool.jupyter-releaser.hooks]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to update the name of the after-draft-release hook.

Need to double check which one to use.

@jtpio
Copy link
Member

jtpio commented Feb 21, 2023

This error:

dist/voila-0.5.0a1-py3-none-any.whl: W002: Wheel contains duplicate files:

Can probably be fixed like in the JupyterLab extension cookiecutter: https://github.com/jupyterlab/extension-cookiecutter-ts/blob/8dca7b37e31bc149ebaae29cc3f942aebf19a88d/%7B%7Bcookiecutter.python_name%7D%7D/pyproject.toml#L85

@martinRenou
Copy link
Member Author

Thanks @jtpio !

@jtpio
Copy link
Member

jtpio commented Feb 21, 2023

We could probably also remove the skip section here:

voila/pyproject.toml

Lines 134 to 137 in eab947e

[tool.jupyter-releaser]
skip = [
"check-links",
]

And add a check-links.yml workflow instead: https://github.com/jupyterlab/maintainer-tools#check-links

@martinRenou
Copy link
Member Author

martinRenou commented Feb 21, 2023

We could probably also remove the skip section here:

Thanks for the suggestion! Let's do that in a separate PR.

@jtpio
Copy link
Member

jtpio commented Feb 21, 2023

Looks like there is also an old reference to jupyter-packaging that could be removed (since Voila is now using hatch).

@martinRenou martinRenou marked this pull request as ready for review February 21, 2023 15:58
@martinRenou martinRenou merged commit 45d595f into voila-dashboards:main Feb 21, 2023
@martinRenou martinRenou deleted the update_check_release branch February 21, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants