Skip to content

Conversation

martinRenou
Copy link
Member

Automated Changelog Entry for 0.4.0a0 on main

Python version: 0.4.0a0
npm version: @voila-dashboards/voila-root: 0.1.0
npm workspace versions:
@voila-dashboards/jupyterlab-preview: 2.2.0-alpha.0
@voila-dashboards/voila: 0.4.0-alpha.0

After merging this PR run the "Full Release" Workflow on your fork of jupyter_releaser with the following inputs

Input Value
Draft Release https://github.com/voila-dashboards/voila/releases/tag/untagged-347a9bd071dd8c879f20
Since @voila-dashboards/[email protected]

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch voila-dashboards/voila/changelog-407ebea63b4311edbe4f374f8b8ee1d9

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 67 <- [68 - 77 - 88] -> 128 58 <- [60 - 64 - 74] -> 96 65 <- [68 - 75 - 83] -> 103 74 <- [80 - 91 - 93] -> 107 2420 <- [2467 - 2598 - 2702] -> 3443 2383 <- [2399 - 2433 - 2448] -> 2629 2568 <- [2590 - 2677 - 2728] -> 2927 2559 <- [2635 - 2699 - 2801] -> 2920 1710 <- [1730 - 1782 - 1811] -> 2047 3136 <- [3140 - 3220 - 3397] -> 3790 8270 <- [8277 - 8308 - 8328] -> 8419 6355 <- [6403 - 6431 - 6490] -> 6687 1237 <- [1363 - 1369 - 1380] -> 1464 2186 <- [2208 - 2305 - 2459] -> 2690
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-09-28 09:08:10.481827834 +0000
+++ /dev/fd/62	2022-09-28 09:08:10.481827834 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281315840
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1020-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.5 LTS",
-      "serial": "1d24188fee7f4944b0cb9c8863cdca51",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@martinRenou
Copy link
Member Author

Looks like the check-release workflow fails now (it was not failing two days ago) with this quite odd error:

npm ERR! code 1
npm ERR! path /tmp/tmp1jvo2yjw/staging/@voila-dashboards/jupyterlab-preview
npm ERR! command failed
npm ERR! command sh /tmp/prepare-a69fef62.sh
npm ERR! yarn run v1.21.1
npm ERR! $ jlpm run clean:lib && jlpm run clean:labextension
npm ERR! $ rimraf lib tsconfig.tsbuildinfo
npm ERR! $ rimraf ../../voila/labextension
npm ERR! Done in 1.45s.
npm ERR! yarn run v1.21.1
npm ERR! $ jlpm run build:lib && jlpm run build:labextension
npm ERR! $ tsc
npm ERR! Version 4.1.6
npm ERR! Syntax:   tsc [options] [file...]
npm ERR!
npm ERR! Examples: tsc hello.ts
npm ERR!           tsc --outFile file.js file.ts
npm ERR!           tsc @args.txt
npm ERR!           tsc --build tsconfig.json
npm ERR!
npm ERR! Options:
npm ERR!  -h, --help                                         Print this message.
npm ERR!  -w, --watch                                        Watch input files.
npm ERR!  --pretty                                           Stylize errors and messages using color and context (experimental).
npm ERR!  --all                                              Show all compiler options.
npm ERR!  -v, --version                                      Print the compiler's version.
npm ERR!  --init                                             Initializes a TypeScript project and creates a tsconfig.json file.
npm ERR!  -p FILE OR DIRECTORY, --project FILE OR DIRECTORY  Compile the project given the path to its configuration file, or to a folder with a 'tsconfig.json'.
npm ERR!  -b, --build                                        Build one or more projects and their dependencies, if out of date
npm ERR!  -t VERSION, --target VERSION                       Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'.
npm ERR!  -m KIND, --module KIND                             Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'.
npm ERR!  --lib                                              Specify library files to be included in the compilation.
npm ERR!                                                       'es5' 'es6' 'es2015' 'es7' 'es2016' 'es2017' 'es2018' 'es2019' 'es2020' 'esnext' 'dom' 'dom.iterable' 'webworker' 'webworker.importscripts' 'webworker.iterable' 'scripthost' 'es2015.core' 'es2015.collection' 'es2015.generator' 'es2015.iterable' 'es2015.promise' 'es2015.proxy' 'es2015.reflect' 'es2015.symbol' 'es2015.symbol.wellknown' 'es2016.array.include' 'es2017.object' 'es2017.sharedmemory' 'es2017.string' 'es2017.intl' 'es2017.typedarrays' 'es2018.asyncgenerator' 'es2018.asynciterable' 'es2018.intl' 'es2018.promise' 'es2018.regexp' 'es2019.array' 'es2019.object' 'es2019.string' 'es2019.symbol' 'es2020.bigint' 'es2020.promise' 'es2020.sharedmemory' 'es2020.string' 'es2020.symbol.wellknown' 'es2020.intl' 'esnext.array' 'esnext.symbol' 'esnext.asynciterable' 'esnext.intl' 'esnext.bigint' 'esnext.string' 'esnext.promise' 'esnext.weakref'
npm ERR!  --allowJs                                          Allow javascript files to be compiled.
npm ERR!  --jsx KIND                                         Specify JSX code generation: 'preserve', 'react-native', or 'react'.
npm ERR!  -d, --declaration                                  Generates corresponding '.d.ts' file.
npm ERR!  --declarationMap                                   Generates a sourcemap for each corresponding '.d.ts' file.
npm ERR!  --sourceMap                                        Generates corresponding '.map' file.
npm ERR!  --outFile FILE                                     Concatenate and emit output to single file.
npm ERR!  --outDir DIRECTORY                                 Redirect output structure to the directory.
npm ERR!  --removeComments                                   Do not emit comments to output.
npm ERR!  --noEmit                                           Do not emit outputs.
npm ERR!  --strict                                           Enable all strict type-checking options.
npm ERR!  --noImplicitAny                                    Raise error on expressions and declarations with an implied 'any' type.
npm ERR!  --strictNullChecks                                 Enable strict null checks.
npm ERR!  --strictFunctionTypes                              Enable strict checking of function types.
npm ERR!  --strictBindCallApply                              Enable strict 'bind', 'call', and 'apply' methods on functions.
npm ERR!  --strictPropertyInitialization                     Enable strict checking of property initialization in classes.
npm ERR!  --noImplicitThis                                   Raise error on 'this' expressions with an implied 'any' type.
npm ERR!  --alwaysStrict                                     Parse in strict mode and emit "use strict" for each source file.
npm ERR!  --noUnusedLocals                                   Report errors on unused locals.
npm ERR!  --noUnusedParameters                               Report errors on unused parameters.
npm ERR!  --noImplicitReturns                                Report error when not all code paths in function return a value.
npm ERR!  --noFallthroughCasesInSwitch                       Report errors for fallthrough cases in switch statement.
npm ERR!  --types                                            Type declaration files to be included in compilation.
npm ERR!  --esModuleInterop                                  Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'.
npm ERR!  @<file>                                            Insert command line options and files from a file.
npm ERR! info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! error Command failed with exit code 1.
npm ERR! error Command failed with exit code 1.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-09-23T14_51_46_716Z-debug-0.log
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.7/x64/bin/jupyter-releaser", line 8, in <module>
    sys.exit(main())
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/cli.py", line 115, in invoke
    super().invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/click/core.py", line [1657](https://github.com/voila-dashboards/voila/actions/runs/3098072940/jobs/5048372555#step:6:1667), in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/cli.py", line 498, in check_npm
    npm.check_dist(dist_dir, npm_install_options)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/npm.py", line 102, in check_dist
    util.run(f"npm install {install_options} {install_str}", cwd=td, quiet=True)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/util.py", line 93, in run
    raise e
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/util.py", line 85, in run
    process = tee(cmd, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/tee.py", line 155, in run
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command 'npm install  ./staging/@voila-dashboards/jupyterlab-preview' returned non-zero exit status 1.
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/actions/draft_release.py", line 59, in <module>
    run_action("jupyter-releaser check-npm")
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/actions/common.py", line 21, in run_action
    _run(target, *args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/util.py", line 93, in run
    raise e
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/util.py", line 85, in run
    process = tee(cmd, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/jupyter_releaser/tee.py", line 155, in run
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command 'jupyter-releaser check-npm' returned non-zero exit status 1.

I checked locally, just tsc is a valid command with TypeScript Version 4.1.6, so I don't know why it's failing and showing help on this workflow.

@jtpio
Copy link
Member

jtpio commented Sep 26, 2022

Also curious whether 0.4.0a0 was intended, since this comment mentions making a patch release? #1203 (comment)

Although a 0.4.0 release sounds totally fine if it includes support for ipywidgets 8.

@martinRenou
Copy link
Member Author

We've been discussing on Gitter whether or not the ipywidgets 7 support drop should be considered a breaking change, and we agreed it is.

@jtpio
Copy link
Member

jtpio commented Sep 27, 2022

I checked locally, just tsc is a valid command with TypeScript Version 4.1.6, so I don't know why it's failing and showing help on this workflow.

This also seems to be happening on other repos, for example: https://github.com/jupyter-server/jupyter-resource-usage/actions/runs/3131101795/jobs/5087206875

@jtpio
Copy link
Member

jtpio commented Sep 28, 2022

This should now be fixed by #1208

@martinRenou martinRenou force-pushed the changelog-407ebea63b4311edbe4f374f8b8ee1d9 branch from 1d4d19f to 74a90ce Compare September 28, 2022 08:47
@jtpio
Copy link
Member

jtpio commented Sep 28, 2022

Maybe the changelog PR should be recreated to include the new entries.

@martinRenou
Copy link
Member Author

Oh right. Let's close this

@martinRenou martinRenou deleted the changelog-407ebea63b4311edbe4f374f8b8ee1d9 branch September 28, 2022 08:53
@jtpio jtpio mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants