Update nbconvert pinning #1161

martinRenou · 2022-06-16T08:06:32Z

Update nbconvert pinning

References

Resolve #1160

github-actions · 2022-06-16T08:06:56Z

👈 Launch a Binder on branch martinRenou/voila/test_nbconvert_master

jtpio · 2022-09-29T10:47:38Z

Maybe this PR could now be about raising the upper bounds for nbclient and nbconvert?

voila/setup.cfg

Lines 39 to 40 in 55d0cb0

    
           nbclient>=0.4.0,<0.6 
        
           nbconvert>=6.4.5,<7

pyproject.toml

martinRenou · 2022-09-30T15:54:21Z

I can't understand yet why the tests fail in the CI with this AttributeError: module 'mistune' has no attribute 'Renderer'.

I'm also running Mistune 2.0.4 locally and it works just fine to run the tests.

jtpio · 2022-09-30T16:42:14Z

I just tried in a clean environment (Gitpod) and also getting the same error as in the CI tests:

jtpio · 2022-09-30T16:50:45Z

Looking at the diff in jupyter/nbconvert#1764, we might need to update this line to something like mistune.HTMLRenderer:

voila/voila/exporter.py

Line 45 in fbba623

markdown_renderer_class = traitlets.Type('mistune.Renderer').tag(config=True)

martinRenou · 2022-10-03T07:20:34Z

I was in this weird installation where conda list would show me Mistune 2.0.4 while I was actually using 0.8.

martinRenou · 2022-10-03T15:36:58Z

The failing test seems to be due to the change in validate/normalize logic introduced by jupyter/nbconvert@8c1146d and jupyter/nbformat#282.

martinRenou · 2022-10-04T07:18:01Z

The failing test seems to be due to the change in validate/normalize logic introduced by jupyter/nbconvert@8c1146d and jupyter/nbformat#282.

Indeed the failing test was originated from those, because nbconvert is now less permissive with invalid Notebooks, and papermill generates an invalid Notebook (see nteract/papermill#686 (comment)). Bumping our test Notebook version fixes it.

voila/exporter.py

We need a class that can accept a contents_manager as parameter, this is not the case anymore with the new Mistune HTMLRenderer so we need to be more specific with the required trait

pyproject.toml

github-actions · 2022-10-04T08:04:13Z

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table

Test file	voila-tree-classic.ipynb	voila-tree-light.ipynb	voila-tree-dark.ipynb	voila-tree-miami.ipynb	basics.ipynb	bqplot.ipynb	dashboard.ipynb	gridspecLayout.ipynb	interactive.ipynb	ipympl.ipynb	ipyvolume.ipynb	multiple_widgets.ipynb	query-strings.ipynb	reveal.ipynb
Render
`chromium`
actual	110 <- [124 - 152 - 191] -> 327	65 <- [69 - 76 - 90] -> 114	62 <- [67 - 76 - 89] -> 120	60 <- [64 - 71 - 82] -> 108	2337 <- [2405 - 2450 - 2603] -> 3190	2090 <- [2119 - 2121 - 2216] -> 2441	2335 <- [2394 - 2454 - 2465] -> 2704	2338 <- [2399 - 2463 - 2538] -> 2644	1786 <- [1796 - 1811 - 1860] -> 2071	2998 <- [3076 - 3257 - 3533] -> 4651	7927 <- [7934 - 7938 - 7960] -> 8020	5758 <- [5793 - 5808 - 5913] -> 6160	1105 <- [1233 - 1249 - 1264] -> 1266	2103 <- [2152 - 2191 - 2199] -> 2205
expected	3379 <- [3442 - 3517 - 3701] -> 3876	2976 <- [3227 - 3321 - 3421] -> 3604	3608 <- [3623 - 3709 - 3793] -> 3825	4453 <- [4453 - 4523 - 4661] -> 4748	2559 <- [2655 - 2656 - 2660] -> 2674	3982 <- [4079 - 4213 - 4356] -> 4743	12183 <- [18509 - 19553 - 20811] -> 21515	15319 <- [15660 - 15796 - 15912] -> 16056	1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed

--- /dev/fd/63	2022-10-04 08:01:49.093725752 +0000
+++ /dev/fd/62	2022-10-04 08:01:49.093725752 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8370C",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
-        "l1d": 98304,
+        "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 50331648
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "106",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.8,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "6",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281315840
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1020-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.5 LTS",
-      "serial": "1d24188fee7f4944b0cb9c8863cdca51",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

jtpio

Thanks!

jtpio · 2022-10-04T08:41:24Z

Starting a new pre-release now: #1225

martinRenou added the maintenance label Jun 16, 2022

martinRenou marked this pull request as draft June 27, 2022 12:56

trungleduc force-pushed the test_nbconvert_master branch from cf21f85 to dd44b06 Compare August 4, 2022 12:23

jtpio added this to the 0.4.0 milestone Sep 29, 2022

martinRenou force-pushed the test_nbconvert_master branch from dd44b06 to c58b20e Compare September 30, 2022 14:42

martinRenou changed the title ~~UI-tests against nbconvert master~~ Update nbconvert and nbclient pinning Sep 30, 2022

martinRenou marked this pull request as ready for review September 30, 2022 14:44

martinRenou added the enhancement New feature or request label Sep 30, 2022

martinRenou commented Sep 30, 2022

View reviewed changes

pyproject.toml Show resolved Hide resolved

martinRenou changed the title ~~Update nbconvert and nbclient pinning~~ Update nbconvert pinning Sep 30, 2022

martinRenou marked this pull request as draft October 3, 2022 08:32

martinRenou added the dependencies Pull requests that update a dependency file label Oct 3, 2022

martinRenou added 6 commits October 4, 2022 09:19

Update nbconvert and nbclient dependencies

cee863c

Update pyproject.toml

5873f23

Update mistune import

d21d7ac

Update Markdown exporter

2e2f5cd

Support both nbconvert 6 and 7

41ec8ac

Fix test

ccd9f1d

martinRenou force-pushed the test_nbconvert_master branch from d158a7b to ccd9f1d Compare October 4, 2022 07:20

martinRenou marked this pull request as ready for review October 4, 2022 07:25

jtpio reviewed Oct 4, 2022

View reviewed changes

voila/exporter.py Outdated Show resolved Hide resolved

Update ui-tests references

236ab8d

Require an instance of VoilaMarkdownRenderer

d06aa5b

We need a class that can accept a contents_manager as parameter, this is not the case anymore with the new Mistune HTMLRenderer so we need to be more specific with the required trait

martinRenou commented Oct 4, 2022

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

Fix nbclient pinning

268511d

martinRenou requested a review from jtpio October 4, 2022 08:15

jtpio approved these changes Oct 4, 2022

View reviewed changes

jtpio merged commit 8244587 into voila-dashboards:main Oct 4, 2022

martinRenou deleted the test_nbconvert_master branch October 4, 2022 08:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update nbconvert pinning #1161

Update nbconvert pinning #1161

Uh oh!

martinRenou commented Jun 16, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Jun 16, 2022

Uh oh!

jtpio commented Sep 29, 2022

Uh oh!

Uh oh!

martinRenou commented Sep 30, 2022 •

edited

Loading

Uh oh!

jtpio commented Sep 30, 2022

Uh oh!

jtpio commented Sep 30, 2022

Uh oh!

martinRenou commented Oct 3, 2022

Uh oh!

martinRenou commented Oct 3, 2022

Uh oh!

martinRenou commented Oct 4, 2022

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 4, 2022 •

edited

Loading

Uh oh!

jtpio left a comment

Uh oh!

jtpio commented Oct 4, 2022

Uh oh!

Uh oh!

Update nbconvert pinning #1161

Update nbconvert pinning #1161

Uh oh!

Conversation

martinRenou commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

Uh oh!

github-actions bot commented Jun 16, 2022

Uh oh!

jtpio commented Sep 29, 2022

Uh oh!

Uh oh!

martinRenou commented Sep 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtpio commented Sep 30, 2022

Uh oh!

jtpio commented Sep 30, 2022

Uh oh!

martinRenou commented Oct 3, 2022

Uh oh!

martinRenou commented Oct 3, 2022

Uh oh!

martinRenou commented Oct 4, 2022

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark report

Uh oh!

jtpio left a comment

Choose a reason for hiding this comment

Uh oh!

jtpio commented Oct 4, 2022

Uh oh!

Uh oh!

martinRenou commented Jun 16, 2022 •

edited

Loading

martinRenou commented Sep 30, 2022 •

edited

Loading

github-actions bot commented Oct 4, 2022 •

edited

Loading