Skip to content

Conversation

martinRenou
Copy link
Member

References

In combination with jupyter/nbconvert#1704, it fixes an issue where the background for Matplotlib figures is not correct.

Code changes

Change the body tag to add the missing data-jp-theme-light and data-jp-theme-name properties.

User-facing changes

Before

before

After

after

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/template_fix_body

@martinRenou martinRenou added the enhancement New feature or request label Jan 12, 2022
@trungleduc
Copy link
Member

Thanks @martinRenou!

@trungleduc trungleduc added the bug Something isn't working label Jan 12, 2022
@trungleduc trungleduc merged commit 2ab11c8 into voila-dashboards:main Jan 12, 2022
@martinRenou martinRenou deleted the template_fix_body branch January 12, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants