Updating Heroku deploy instructions #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Python runtime is not valid. I've: - Updated the Python runtime - Added a link to Heroku's docs on Python runtimes so if/when the new runtime becomes invalid, it is easy to find the updated one
|
|
fhightower
changed the title
fhightower
commented
Dec 8, 2021
| .. code:: text | ||
| web: voila —-port=$PORT --no-browser | ||
| web: voila --port=$PORT --no-browser |
There was a problem hiding this comment.
I replaced this character (and throughout the file) as it was a Unicode character (I believe an em dash).
|
RTD build passes and other CI failures are not related. |
|
Ah looks like this was targeting the @meeseeksdev please backport to main |
meeseeksmachine
pushed a commit
to meeseeksmachine/voila
that referenced
this pull request
Dec 8, 2021
trungleduc
added a commit
that referenced
this pull request
Dec 8, 2021
…7-on-main Backport PR #1037 on branch main (Updating Heroku deploy instructions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to replacing a Unicode character with it's ascii replacement, I've also updated the Python runtime as the one listed is no longer valid. Specifically, I've:
I chose not to use the latest runtime (
3.10.0) as I'm not sure that (based on #1027) that voila supports Python 3.10.x yet.