-
Notifications
You must be signed in to change notification settings - Fork 527
Closed
Labels
bugSomething isn't workingSomething isn't working
Milestone
Description
Description
At the moment the benchmark workflow overwrites the Binder badge comment:
Reproduce
Example: #993
Expected behavior
This logic would need to handle other comments that are not benchmark comments:
voila/.github/workflows/benchmark-report.yml
Lines 61 to 70 in 4cf7eaf
| // Find any comment already made by the bot. | |
| const botComment = comments.find(comment => comment.user.id === 41898282) | |
| if (botComment) { | |
| await github.issues.updateComment({ | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| comment_id: botComment.id, | |
| body: report | |
| }) | |
| } else { |
Context
Noticed in #993 (comment)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
