Skip to content

Use ruff instead of flake8, run black #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 23, 2023
Merged

Use ruff instead of flake8, run black #49

merged 6 commits into from
Mar 23, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 23, 2023

References

ruff is getting a lot of traction and has been adopted on many Jupyter projects already.

Code changes

  • Remove flake8 config
  • Use ruff
  • Run black on the code base
  • Add simple CI check to run ruff and black

A follow-up could be to add pre-commit like in Voila: voila-dashboards/voila#1306

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio changed the title Use ruff insteadk of flake8, run black Use ruff instead of flake8, run black Mar 23, 2023
@jtpio jtpio changed the title Use ruff instead of flake8, run black Use ruff instead of flake8, run black Mar 23, 2023
@jtpio jtpio marked this pull request as ready for review March 23, 2023 17:52
@trungleduc trungleduc merged commit 8069c95 into voila-dashboards:main Mar 23, 2023
@jtpio jtpio deleted the ruff branch March 23, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @trungleduc