Skip to content

Conversation

@kevinconley19
Copy link

No description provided.

@ahesford
Copy link
Member

Don't close PRs just to change the version. Push your changes to the original branch and update the title.

@kevinconley19
Copy link
Author

kevinconley19 commented Oct 30, 2025

Sorry - i had some issues and just deleted and repushed the branch minus the previous update. I guess GH just closed the PR when i deleted the old branch?


# Remove unused icons
rm ${DESTDIR}/opt/google/chrome/*.xpm
rm -f ${DESTDIR}/opt/google/chrome/*.xpm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-f means it won't error when it's removing files that no longer exist

Copy link
Author

@kevinconley19 kevinconley19 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - and if you want to remove unused icons this catches all situations. Google can add/remove icon whenever and it wont break the package. I added the flag b/c it was failing on no *.xpm files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want to leave extra lines in the template after things change in the package. if the distfile no longer has those files, it's a useless line and we should remove it. adding -f hides this fact

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol - ended up doing that way anyways

@kevinconley19 kevinconley19 deleted the google-chrome branch November 5, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants