Skip to content

libde265: patch to fix getting marked as execstack #56423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

libde265: patch to fix getting marked as execstack #56423

merged 1 commit into from
Aug 5, 2025

Conversation

TinfoilSubmarine
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Fixes #56252. Maybe we should gate the LDFLAGS to only armv7l, but also haven't tested to see if the issue occurs on other machine types...

@oreo639
Copy link
Member

oreo639 commented Jul 30, 2025 •
edited
Loading

Sorry for the late response.
Thanks for the PR, this should probably be reported upstream.

From what I can tell the issue is because neon.S, despite just being an include file is listed in prog_SOURCES (and thus gets assembled into an object file, which assumes executable stack since it is assembly).
While asm.S explicitly disables executable stack, neon.S, which is supposed to be included alongside neon.S, does not: https://github.com/strukturag/libde265/blob/578d76e5f6a41d2fb735124077dfa8a453b69bc4/libde265/arm/neon.S

neon.S should probably be moved from prog_SOURCES to EXTRA_DIST and that does appear to fix the executable stack issue: https://github.com/strukturag/libde265/blob/578d76e5f6a41d2fb735124077dfa8a453b69bc4/libde265/arm/Makefile.am#L32

@oreo639
Copy link
Member

oreo639 commented Jul 30, 2025

strukturag/libde265#479

@TinfoilSubmarine
Copy link
Contributor Author

Cool, thanks! Should I pull that patch into this PR, or how do you want to proceed?

@oreo639
Copy link
Member

oreo639 commented Aug 4, 2025 •
edited
Loading

Should I pull that patch into this PR

Yeah, thanks.

@TinfoilSubmarine TinfoilSubmarine changed the title libde265: disable execstack for glibc-2.41 libde265: patch to fix getting marked as execstack Aug 5, 2025
oreo639
oreo639 reviewed Aug 5, 2025
View reviewed changes
srcpkgs/libde265/template Outdated
@@ -12,6 +12,10 @@ changelog="https://github.com/strukturag/libde265/releases"
distfiles="https://github.com/strukturag/libde265/releases/download/v${version}/libde265-${version}.tar.gz"
checksum=b92beb6b53c346db9a8fae968d686ab706240099cdd5aff87777362d668b0de7

if [[ "$XBPS_TARGET_MACHINE" == arm* ]]; then
hostmakedepends+=" automake"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be unconditional.

@oreo639 oreo639 merged commit 41866cc into void-linux:master Aug 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oreo639 oreo639 oreo639 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP: unable to load dynamic library 'gd'
2 participants
@TinfoilSubmarine @oreo639