build: upgrade go directive in go.mod to 1.17 #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
reviewed
Nov 30, 2021
This commit enables support for module graph pruning and lazy module loading for projects that are at Go 1.17 or higher. Reference: https://go.dev/ref/mod#go-mod-file-go Reference: https://go.dev/ref/mod#graph-pruning Reference: https://go.dev/ref/mod#lazy-loading Signed-off-by: Eng Zer Jun <[email protected]>
|
@akutz Hi, I have moved the |
|
I did a quick test with these changes and bumped the Go versions used in the various workflows to include |
dougm
approved these changes
Dec 8, 2021
|
@Juneezee, VMware has approved your signed contributor license agreement. |
embano1
pushed a commit
to embano1/govmomi
that referenced
this pull request
Dec 10, 2021
Uses Go 1.17 for build-related steps and matrix 1.16 and 1.17 for tests (see vmware#2674) Closes: vmware#2679 Signed-off-by: Michael Gasch <[email protected]>
yuyin002
pushed a commit
to yuyin002/govmomi
that referenced
this pull request
Jan 12, 2022
Uses Go 1.17 for build-related steps and matrix 1.16 and 1.17 for tests (see vmware#2674) Closes: vmware#2679 Signed-off-by: Michael Gasch <[email protected]>
yuyin002
pushed a commit
to yuyin002/govmomi
that referenced
this pull request
Jan 12, 2022
Uses Go 1.17 for build-related steps and matrix 1.16 and 1.17 for tests (see vmware#2674) Closes: vmware#2679 Signed-off-by: Michael Gasch <[email protected]>
yuyin002
pushed a commit
to yuyin002/govmomi
that referenced
this pull request
Jan 15, 2022
Uses Go 1.17 for build-related steps and matrix 1.16 and 1.17 for tests (see vmware#2674) Closes: vmware#2679 Signed-off-by: Michael Gasch <[email protected]>
pradeep288
pushed a commit
to pradeep288/govmomi
that referenced
this pull request
Jan 17, 2022
Uses Go 1.17 for build-related steps and matrix 1.16 and 1.17 for tests (see vmware#2674) Closes: vmware#2679 Signed-off-by: Michael Gasch <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the
godirective ingo.modfile by runninggo mod tidy -go=1.17to enable module graph pruning and lazy module loading supported by Go 1.17 or higher.Note 1: This does not prevent users with earlier Go versions from successfully building packages from this module.
Note 2: The additional
requiredirective is used to record indirect dependencies by Go 1.17 or higher, see https://go.dev/ref/mod#go-mod-file-go.Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Manually tested by running
make test.Checklist:
this project