Skip to content

govc: validate library.deploy arguments #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2021
Merged

govc: validate library.deploy arguments #2636

merged 1 commit into from
Oct 26, 2021

Conversation

dougm
Copy link
Member

@dougm dougm commented Oct 21, 2021

Description

  • add example of using library.export to generate options.json

Fixes #2599
Fixes #2598

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@dougm
govc: validate library.deploy arguments
8fde8bc 
- add example of using library.export to generate options.json

Fixes vmware#2599
Fixes vmware#2598
embano1
embano1 approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougm dougm merged commit f0985ac into vmware:master Oct 26, 2021
@dougm dougm deleted the issue-2599 branch October 26, 2021 03:03
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@embano1 embano1 embano1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] library.deploy does not honor OVA spec file via -options (properties) [BUG] library.deploy behavior does not match description
3 participants
@dougm @embano1 @vmwclabot