Skip to content

[BugFix] fix group_topk #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

[BugFix] fix group_topk #8430

merged 2 commits into from
Sep 13, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Sep 12, 2024 •
edited
Loading

Summary

  • The current group_topk seems to only work for unquantized models; update the return type on the expert selection to fix gibberish outputs on fused marlin kernels

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 12, 2024
mgoin
mgoin approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, looking forward to evaluating quantized deepseek v2.5 with this :)

@DarkLight1337 DarkLight1337 merged commit 8f44a92 into vllm-project:main Sep 13, 2024
59 checks passed
@dsikka dsikka deleted the fix_grouptopk branch September 13, 2024 16:15
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@dsikka @Alvant
[BugFix] fix group_topk (vllm-project#8430)
ba7ee4f 
Signed-off-by: Alvant <[email protected]>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@dsikka @LeiWang1999
[BugFix] fix group_topk (vllm-project#8430)
1e3af7c 
Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsikka @mgoin @DarkLight1337