Skip to content

Fix the AMD weight loading tests #8390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix the AMD weight loading tests #8390

merged 2 commits into from
Sep 12, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Sep 12, 2024 •
edited by DarkLight1337
Loading

FIX #8392
FIX #8397

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 12, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

youkaichao
youkaichao reviewed Sep 12, 2024
View reviewed changes
vllm/config.py
@@ -876,8 +876,8 @@ def __init__(
from vllm.executor import ray_utils
backend = "mp"
ray_found = ray_utils.ray_is_available()
if (torch.cuda.is_available()
and cuda_device_count_stateless() < self.world_size):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use if current_platform.is_cuda()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuda_device_count_stateless() can raise error in other platforms

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is definitely better to use and seems to work locally

@youkaichao youkaichao mentioned this pull request Sep 12, 2024
Closed
1 task
youkaichao
youkaichao approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@youkaichao
Copy link
Member

weight loading passed, considering the emergence, let's directly merge it.

@youkaichao youkaichao merged commit b6c75e1 into main Sep 12, 2024
34 of 39 checks passed
@youkaichao youkaichao deleted the fix-parallel-config-device-count branch September 12, 2024 03:35
@DarkLight1337 DarkLight1337 mentioned this pull request Sep 12, 2024
Closed
1 task
@simon-mo simon-mo mentioned this pull request Sep 12, 2024
Closed
7 tasks
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@mgoin @Alvant
Fix the AMD weight loading tests (vllm-project#8390)
c36e21b 
Signed-off-by: Alvant <[email protected]>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@mgoin @LeiWang1999
Fix the AMD weight loading tests (vllm-project#8390)
7ae2475 
Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
2 participants
@mgoin @youkaichao