Skip to content

[Bugfix]: Fix the logic for deciding if tool parsing is used #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[Bugfix]: Fix the logic for deciding if tool parsing is used #8366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48052a9
bugfx: Fix the logic for deciding if tool parsing is used
tomeras91 Sep 11, 2024
5516663
fix logic again following PR comment
tomeras91 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/entrypoints/openai/serving_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ async def chat_completion_full_generator(

# if auto tools are not enabled, and a named tool choice using
# outlines is not being used
if not (self.enable_auto_tools
if (not self.enable_auto_tools
or not self.tool_parser) and not isinstance(
request.tool_choice,
ChatCompletionNamedToolChoiceParam):
Expand Down
Loading