-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Kernel][Hardware][Amd]Custom paged attention kernel for rocm #8310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel][Hardware][Amd]Custom paged attention kernel for rocm #8310
Conversation
…on_kernel_on_rocm
…on_kernel_on_rocm
…on_kernel_on_rocm
…tps://github.com/charlifu/vllm into charlifu/separate_paged_attention_kernel_on_rocm
…on_kernel_on_rocm
…tps://github.com/charlifu/vllm into charlifu/separate_paged_attention_kernel_on_rocm
…on_kernel_on_rocm
…tps://github.com/charlifu/vllm into charlifu/separate_paged_attention_kernel_on_rocm
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charlifu Thanks for upstreaming the kernel and also adding the test!
It looks good to me overall, but I have a few suggestions:
- Move
use_rocm_paged_attention
inselected.py
torocm_flash_attn.py
. - Cache
rocm_paged_attention_available
inuse_rocm_paged_attention
to minimize its overheads. - In
rocm_flash_attn.py
, userocm_paged_attention_available
to decide betweenPagedAttention.forward_decode
andops.paged_attention_rocm
. This way, we will be able to keeppaged_attn.py
untouched by this PR.
@pytest.mark.parametrize("version", ["rocm"]) | ||
@pytest.mark.parametrize("num_seqs", NUM_GEN_SEQS) | ||
@pytest.mark.parametrize("num_heads", NUM_HEADS) | ||
@pytest.mark.parametrize("head_size", [64, 128]) # only test 64 128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because other head sizes are not supported? Or, is it just for reducing the cost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other sizes are not supported yet, we will add them in subsequent PR.
Co-authored-by: Woosuk Kwon <[email protected]>
…on_kernel_on_rocm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing my review!
…roject#8310) Signed-off-by: Alvant <[email protected]>
…roject#8310) Signed-off-by: Amit Garg <[email protected]>
…roject#8310) Signed-off-by: LeiWang1999 <[email protected]>
This PR adds custom paged attention kernel support for rocm.
Todo:
Performance improvement (llama-2-70b-chat-hf):
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!