Skip to content

[Performance] Enable chunked prefill and prefix caching together #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Sep 3, 2024

[Do not auto-merge] Add missing co-athors of #7753

Co-authored-by: Tao He [email protected]
Co-authored-by: Juelianqvq [email protected]

Co-authored-by: Tao He <[email protected]>
Co-authored-by: Juelianqvq <[email protected]>
Copy link

github-actions bot commented Sep 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 3, 2024
@comaniac comaniac enabled auto-merge (squash) September 3, 2024 17:37
@comaniac comaniac disabled auto-merge September 3, 2024 17:37
@comaniac comaniac merged commit bd852f2 into vllm-project:main Sep 3, 2024
36 checks passed
@comaniac comaniac deleted the cp_apc_author branch September 3, 2024 17:49
@sighingnow
Copy link
Collaborator

@comaniac Thank you ❤️ !

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants