[Benchmark] Add --async-engine option to benchmark_throughput.py
#7964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses AsyncLLMEngine interface (or rather than LLM) Will use decoupled front-end depending on whether or not --disable-frontend-multiprocessing is also specified.
njhill
force-pushed
the
async-llm-eng-bench
branch
from
a7a6e43 to
bd5ba81
Compare
njhill
changed the title
njhill
changed the title
--async-engine option to benchmark_throughput.py
comaniac
approved these changes
Sep 4, 2024
Comment on lines
+336
to
+340
| if args.async_engine: | ||
| run_args.append(args.disable_frontend_multiprocessing) | ||
| elapsed_time = uvloop.run(run_vllm_async(*run_args)) | ||
| else: | ||
| elapsed_time = run_vllm(*run_args) |
There was a problem hiding this comment.
Nit: better to use kwargs
There was a problem hiding this comment.
Agree, but the list was already passed as regular args so this involved minimal changes.
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…llm-project#7964) Signed-off-by: Alvant <[email protected]>
LeiWang1999
pushed a commit
to LeiWang1999/vllm-bitblas
that referenced
this pull request
Mar 26, 2025
…llm-project#7964) Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses AsyncLLMEngine interface (rather than LLM)
Will use decoupled front-end depending on whether or not
--disable-frontend-multiprocessingis also specified.