Skip to content

[Misc] Update qqq to use vLLMParameters #7805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2024
Merged

[Misc] Update qqq to use vLLMParameters #7805

merged 4 commits into from
Aug 26, 2024
+55 −65

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Aug 23, 2024

Summary

  • Update qqq to use vLLMParameters

@dsikka
Copy link
Contributor Author

dsikka commented Aug 23, 2024

/ready

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 23, 2024
mgoin
mgoin approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgoin mgoin enabled auto-merge (squash) August 23, 2024 18:42
@mgoin mgoin disabled auto-merge August 23, 2024 18:50
mgoin
mgoin requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pausing to check QQQ correctness

@dsikka dsikka requested a review from mgoin August 23, 2024 19:27
@dsikka dsikka force-pushed the update_qqq_params branch from e4471c6 to c952099 Compare August 23, 2024 19:28
@dsikka dsikka force-pushed the update_qqq_params branch from c952099 to cece172 Compare August 26, 2024 15:41
mgoin
mgoin approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@mgoin mgoin merged commit 6653040 into vllm-project:main Aug 26, 2024
44 checks passed
@mgoin mgoin deleted the update_qqq_params branch August 26, 2024 19:16
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@dsikka @Alvant
[Misc] Update qqq to use vLLMParameters (vllm-project#7805)
50428b7 
Signed-off-by: Alvant <[email protected]>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@dsikka @LeiWang1999
[Misc] Update qqq to use vLLMParameters (vllm-project#7805)
5978ec6 
Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsikka @mgoin