-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Frontend] add json_schema support from OpenAI protocol #7654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] add json_schema support from OpenAI protocol #7654
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
491f3a8
to
4202f0b
Compare
thank you for opening this PR! lmk when it is ready for review and test passed! |
ec892c6
to
3bb70ca
Compare
/ready |
3bb70ca
to
7da6dce
Compare
Verified this works locally:
|
OpenAI now supports json_schema and since vLLM already supports this functionality add the ability to plumb the new OpenAI protocol field to vLLM's functionality.
7da6dce
to
63c220f
Compare
This is ready @simon-mo |
Hi! Does this actually work? When I ran the below script, the model generated the redundant ```json token. import openai
from pydantic import BaseModel
client = openai.OpenAI(
base_url="http://localhost:8008/v1",
api_key="sk-no-key-required"
)
class Players(BaseModel):
names: list[str]
completion = client.chat.completions.create(
model="gpt-4o",
messages=[
{"role": "user", "content": "Give me three football players' name and return the result as a JSON object with the key is `names`"}
],
temperature=0.0,
max_tokens=256,
extra_body={
"response_format": {
"type": "json_schema",
"json_schema": {
"name": Players.__name__,
"schema": Players.model_json_schema()
}
}
}
)
print(completion.choices[0].message.content) Output:
BTW, should it be
or
None of the above arguments work as expected. The document doesn't provide a clear instruction on how to use this feature, so can you guys update this? Thanks in advance The model is: |
…#7654) Signed-off-by: Alvant <[email protected]>
…#7654) Signed-off-by: LeiWang1999 <[email protected]>
OpenAI now supports json_schema and since vLLM already supports this
functionality add the ability to plumb the new OpenAI protocol field to
vLLM's functionality.
FIX #7656
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!