Skip to content

[frontend] spawn engine process from api server process #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 13, 2024
Merged

[frontend] spawn engine process from api server process #7484

merged 6 commits into from
Aug 13, 2024

Conversation

youkaichao
Copy link
Member

replace #7411

@youkaichao youkaichao requested a review from njhill August 13, 2024 21:29
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

njhill
njhill reviewed Aug 13, 2024
View reviewed changes
tests/entrypoints/openai/test_oot_registration.py
sampling_metadata: SamplingMetadata,
) -> Optional[torch.Tensor]:
def compute_logits(self, hidden_states: torch.Tensor,
sampling_metadata: SamplingMetadata) -> torch.Tensor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason for this change? it's Optional in the superclass method that it's overriding...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is automatically done by the linter, I think due to the version change of linter.

njhill
njhill approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youkaichao youkaichao mentioned this pull request Aug 13, 2024
Closed
@youkaichao youkaichao linked an issue Aug 13, 2024 that may be closed by this pull request
[Bug]: ngc24.05 "RuntimeError: Cannot re-initialize CUDA in forked subprocess." #7246
Closed
@youkaichao
Copy link
Member Author

should also close #7151

@youkaichao youkaichao merged commit 33e5d7e into vllm-project:main Aug 13, 2024
27 checks passed
@youkaichao youkaichao deleted the spawn_engine branch August 13, 2024 22:40
@youkaichao youkaichao mentioned this pull request Aug 13, 2024
Closed
@ameza13
Copy link

ameza13 commented Aug 14, 2024 •
edited
Loading

Hello, by when will it be a release with this fix available?

@youkaichao
Copy link
Member Author

@ameza13 see #7481

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@youkaichao @Alvant
[frontend] spawn engine process from api server process (vllm-project…
71e2eb1 
…#7484)

Signed-off-by: Alvant <[email protected]>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@youkaichao @LeiWang1999
[frontend] spawn engine process from api server process (vllm-project…
85dedbd 
…#7484)

Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhill njhill njhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ngc24.05 "RuntimeError: Cannot re-initialize CUDA in forked subprocess."
3 participants
@youkaichao @ameza13 @njhill