Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

The documentation build started to fail after #7276 was merged. Let's revert the PR and fix the bug.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@WoosukKwon WoosukKwon merged commit e20233d into main Aug 13, 2024
20 of 22 checks passed
@WoosukKwon WoosukKwon deleted the fix-docs branch August 13, 2024 08:37
@WoosukKwon
Copy link
Collaborator Author

WoosukKwon commented Aug 13, 2024

This indeed resolved the doc failures.

@mgoin The bug is quite subtle. Your PR succeeded in building html files, but failed to generate PDFs. That's why it (and subsequent PRs) passed the CI tests on doc build. I guess the table format has an issue, but am not sure what the exact reason of failure is.

Error log: https://readthedocs.org/api/v2/build/25246172.txt

@mgoin
Copy link
Member

mgoin commented Aug 13, 2024

I see, my apologies for the trouble @WoosukKwon. I will investigate building the pdf locally to see if I can find a better table representation.

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants