[BugFix] Avoid secondary error in ShmRingBuffer destructor #6530
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is an error setting up the shared memory in the ShmRingBuffer initializer, the destructor will raise an additional error: [36m(RayWorkerWrapper pid=371, ip=10.128.21.6)[0m Exception ignored in: <function ShmRingBuffer.__del__ at 0x7f6ce44258a0> [36m(RayWorkerWrapper pid=371, ip=10.128.21.6)[0m Traceback (most recent call last): [36m(RayWorkerWrapper pid=371, ip=10.128.21.6)[0m File "/opt/vllm/lib64/python3.11/site-packages/vllm/distributed/device_communicators/shm_broadcast.py", line 122, in __del__ [36m(RayWorkerWrapper pid=371, ip=10.128.21.6)[0m self.shared_memory.close() [36m(RayWorkerWrapper pid=371, ip=10.128.21.6)[0m ^^^^^^^^^^^^^^^^^^ [36m(RayWorkerWrapper pid=371, ip=10.128.21.6)[0m AttributeError: 'ShmRingBuffer' object has no attribute 'shared_memory'
|
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
youkaichao
reviewed
Jul 18, 2024
github-actions
bot
added
the
ready
fialhocoelho
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jul 19, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…ect#6530) Signed-off-by: Alvant <[email protected]>
LeiWang1999
pushed a commit
to LeiWang1999/vllm-bitblas
that referenced
this pull request
Mar 26, 2025
…ect#6530) Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an error setting up the shared memory in the ShmRingBuffer initializer, the destructor will raise an additional error: