[ Misc ] non-uniform quantization via `compressed-tensors` for `Llama` #6515

robertgshaw2-redhat · 2024-07-17T18:33:14Z

SUMMARY:

add compressed-tensors integration to support for nonuniform quantization
pipe layer_name though llama.py to enable selecting quantization scheme on layer-by-layer basis
add lm-eval test case for an example non-uniform model

FOLLOW UP PRs:

our config parsing is getting complicated. We should add compressed-tensors as a dependency
expand non-uniform to the remaining models (currently only support llama, we will fail loudly but confusingly otherwise)

This enables us to run a model with fp8 for some layers and fp16 for other layers

from vllm import LLM
# this model has fp16, fp8, and int8!
model = LLM("nm-testing/Meta-Llama-3-8B-Instruct-nonuniform-test")

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

github-actions · 2024-07-17T18:33:26Z

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger fastcheck CI to run, which consists only a small and essential subset of tests to quickly catch errors with the flexibility to run extra individual tests on top (you can do this by unblocking test steps in the Buildkite run).

Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well.

To run full CI, you can do one of these:

Comment /ready on the PR
Add ready label to the PR
Enable auto-merge.

🚀

robertgshaw2-redhat · 2024-07-17T22:37:51Z

/ready

vllm/model_executor/layers/quantization/compressed_tensors/utils.py

vllm/model_executor/models/llama.py

youkaichao · 2024-07-18T01:27:00Z

vllm/model_executor/models/utils.py

@@ -65,7 +65,7 @@ def make_layers(
                                            get_pp_group().world_size)
    modules = torch.nn.ModuleList(
        [PPMissingLayer() for _ in range(start_layer)] +
-        [layer_fn() for _ in range(start_layer, end_layer)] +


add prefix="" for make_layers, and pass prefix=f"{prefix}.{_}" to layer_fn

okay sounds good

youkaichao · 2024-07-18T01:29:30Z

vllm/model_executor/models/llama.py

@@ -170,6 +176,7 @@ class LlamaDecoderLayer(nn.Module):

    def __init__(
        self,
+        prefix: str,


add default, and move it to the last arg

youkaichao · 2024-07-18T01:29:46Z

vllm/model_executor/models/llama.py

@@ -129,12 +133,14 @@ def __init__(
            total_num_kv_heads=self.total_num_kv_heads,
            bias=bias,
            quant_config=quant_config,
+            layer_name=f"{prefix}.qkv_proj",


unify them to use prefix

Are you sure?

This is the Linear which is the root. So its no longer a prefix but rather this is the final layer_name

what's the difference?

I also vote for prefix, because Linear is just another torch.nn.module. Unifying the naming might be more clear.

updated to prefix

youkaichao

LGTM, let's change to prefix for the argument name.

youkaichao · 2024-07-18T02:17:35Z

vllm/model_executor/models/utils.py

@@ -53,7 +53,9 @@ def __init__(self, *args, **kwargs):


 def make_layers(
-    num_hidden_layers: int, layer_fn: Callable[[], torch.nn.Module]
+    num_hidden_layers: int,
+    layer_fn: Callable[[], torch.nn.Module],


typing is not correct. you can create a proto for type checking:

class LayerFn(Protocol): def __call__( self, prefix="", ) -> torch.nn.Module: ...

youkaichao · 2024-07-18T02:18:35Z

vllm/model_executor/models/gpt2.py

+            lambda prefix: GPT2Block(config, cache_config, quant_config),
+            prefix="")


update GPT2Block?

youkaichao · 2024-07-18T02:26:36Z

@robertgshaw2-neuralmagic please also merge the latest main and take care of the code in #6516 .

vllm/model_executor/models/llama.py

vllm/model_executor/models/mixtral.py

vllm-project#6515)

vllm-project#6515) Signed-off-by: Alvant <[email protected]>

vllm-project#6515) Signed-off-by: LeiWang1999 <[email protected]>

[email protected] added 6 commits July 17, 2024 00:12

stash

64c3c1c

re-enable nonuniform for llama

8915297

stash

18a71ae

working e2e

197dd19

cleanup code a bit

eb95b49

nonuniform

e3cf135

[email protected] added 4 commits July 17, 2024 19:32

fix nit

c602855

Merge branch 'main' into non-uniform

bf3832c

format

d9355f4

tweak gpt2

f036956

robertgshaw2-redhat marked this pull request as ready for review July 17, 2024 19:59

robertgshaw2-redhat requested review from comaniac, youkaichao, mgoin, WoosukKwon and zhuohan123 July 17, 2024 19:59

added test

ba115eb

robertgshaw2-redhat changed the title ~~[ Misc ] Support non-uniform quantization via compressed-tensors for Llama~~ [ Misc ] non-uniform quantization via compressed-tensors for Llama Jul 17, 2024

github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 17, 2024

mgoin reviewed Jul 17, 2024

View reviewed changes

vllm/model_executor/layers/quantization/compressed_tensors/utils.py Show resolved Hide resolved

vllm/model_executor/models/llama.py Outdated Show resolved Hide resolved

vllm/model_executor/models/llama.py Outdated Show resolved Hide resolved

[email protected] added 2 commits July 18, 2024 01:21

update to parent

6e28ead

format

793abc7

youkaichao reviewed Jul 18, 2024

View reviewed changes

youkaichao approved these changes Jul 18, 2024

View reviewed changes

[email protected] added 2 commits July 18, 2024 01:50

format

bb7d44c

format

24e5cdf

[email protected] added 5 commits July 18, 2024 02:04

revert marlin change on wrong branch

9f7aeca

spurious chnage

5b1369a

finally done

45acd28

replicated linear num lines

87c8c87

remove unnessary changes

477b1ea

robertgshaw2-redhat requested review from youkaichao and mgoin July 18, 2024 02:14

youkaichao reviewed Jul 18, 2024

View reviewed changes

youkaichao mentioned this pull request Jul 18, 2024

[Model] Pipeline Parallel Support for DeepSeek v2 #6519

Merged

[email protected] added 4 commits July 18, 2024 19:46

stash

998c84f

Merge branch 'main' into non-uniform

57c5bc6

staged

a826e66

format

3ab65a7

youkaichao reviewed Jul 18, 2024

View reviewed changes

vllm/model_executor/models/llama.py Outdated Show resolved Hide resolved

youkaichao reviewed Jul 18, 2024

View reviewed changes

vllm/model_executor/models/mixtral.py Outdated Show resolved Hide resolved

[email protected] added 3 commits July 18, 2024 21:10

move root back

4d5fc07

fix mixtral

1fa917e

formatted

1e57ffa

robertgshaw2-redhat merged commit dbe5588 into vllm-project:main Jul 19, 2024
72 checks passed

robertgshaw2-redhat deleted the non-uniform branch July 19, 2024 02:39

cli99 mentioned this pull request Jul 19, 2024

Add FP8 quantization ignored_layers support in llama #6592

Closed

xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024

[ Misc ] non-uniform quantization via compressed-tensors for Llama (

368ef77

vllm-project#6515)

mgoin mentioned this pull request Aug 5, 2024

[CORE] [QUANT] Support for GPTQModel's dynamic quantization per module override/control #7086

Merged

2 tasks

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024

[ Misc ] non-uniform quantization via compressed-tensors for Llama (

b9dcb6d

vllm-project#6515) Signed-off-by: Alvant <[email protected]>

LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025

[ Misc ] non-uniform quantization via compressed-tensors for Llama (

9755f94

vllm-project#6515) Signed-off-by: LeiWang1999 <[email protected]>

		lambda prefix: GPT2Block(config, cache_config, quant_config),
		prefix="")

Uh oh!

[ Misc ] non-uniform quantization via compressed-tensors for Llama #6515

[ Misc ] non-uniform quantization via compressed-tensors for Llama #6515

Uh oh!

Conversation

robertgshaw2-redhat commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Title and Classification

Code Quality

Notes for Large Changes

What to Expect for the Reviews

Thank You

Uh oh!

github-actions bot commented Jul 17, 2024

Uh oh!

robertgshaw2-redhat commented Jul 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

youkaichao Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youkaichao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youkaichao commented Jul 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[ Misc ] non-uniform quantization via `compressed-tensors` for `Llama` #6515

[ Misc ] non-uniform quantization via `compressed-tensors` for `Llama` #6515

robertgshaw2-redhat commented Jul 17, 2024 •

edited

Loading

youkaichao Jul 18, 2024 •

edited

Loading