-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[CI/Build] vLLM cache directory for images #6444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
@WoosukKwon do you think we can move the XLA cache under |
vllm/assets/base.py
Outdated
|
||
def get_cache_dir(): | ||
"""Get the path to the cache for storing downloaded assets.""" | ||
path = Path(VLLM_ASSETS_CACHE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to expanduser here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already done in vllm.env
so no need to do it again here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small comment.
@DarkLight1337 Yes. I think that's good for consistency. |
BTW, we also have config-related cache under |
The only cache I found under that directory is |
LGTM |
Signed-off-by: Alvant <[email protected]>
Signed-off-by: LeiWang1999 <[email protected]>
This PR adds a cache directory for vLLM. Similar to HuggingFace, the location of the cache is given by the environment variable
VLLM_CACHE_ROOT
, or$XDG_CACHE_HOME/vllm
if it is not provided (e.g.~/.cache/vllm
by default). Under this directory, we have two subdirectories for containing different types of data:VLLM_XLA_CACHE_PATH
for XLA persistent cache directory. cc @WoosukKwonVLLM_ASSETS_CACHE
for downloaded assets.s3
orcurl
to download the images used in VLM examples and tests. cc @xwjiang2010Accordingly,
VLLM_CONFIG_ROOT
has been updated to take thevllm
directory into account. This means that:$XDG_CONFIG_HOME
to$XDG_CONFIG_HOME/vllm
.VLLM_CONFIG_ROOT
should no longer prependvllm/
since that is included in the environment variable already.