-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Hardware][NV] Add support for ModelOpt static scaling checkpoints. #6112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With the utilities that I made for fp8, all of the core functionality of fp8 is now refactored out of With the utilities, I made, this PR should not need to touch |
Utilities are in and this PR should now be unblocked |
29159cd
to
c757e69
Compare
58a21c2
to
826a724
Compare
826a724
to
6b9ac06
Compare
@robertgshaw2-neuralmagic @simon-mo @youkaichao Please review 🙏 |
@dsikka going to review |
quant_config = cls.get_from_keys(config, ["quantization"]) | ||
quant_method = quant_config["quant_algo"] | ||
is_checkpoint_fp8_serialized = ("FP8" in quant_method) | ||
activation_scheme = "static" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should check the config matches here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config doesn't record "static" or "dynamic" with Model Optimizer config at the moment since it is only relevant for static quantization:
{
"producer": {
"name": "modelopt",
"version": "0.17.0"
},
"quantization": {
"quant_algo": "FP8",
"kv_cache_quant_algo": null
}
}
Removing references to "static" since it doesn't look relevant for this quantization class.
This change adds support for a new quantization class that has the ability to load ModelOpt checkpoints through HF. It can be invoked via - llm = LLM(model=model_path, quantization="modelopt") The checkpoint needs a hf_quant_config.json for loading the right quantiztion format. This config can be used to load the nvidia/llama-3.1-*-FP8 models that are quantized using NVIDIA Model Optimzier, and available on HF.
877fa68
to
efe1fe3
Compare
/ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good enough for now to land! Looking forward to a model checkpoint to test. You may want to merge with main to get the CI to pass
|
||
MAX_MODEL_LEN = 1024 | ||
|
||
MODELS = ["nvidia/Llama-3.1-8B-Instruct-FP8"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a note that this model doesn't exist yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…llm-project#6112) Signed-off-by: Alvant <[email protected]>
…llm-project#6112) Signed-off-by: Amit Garg <[email protected]>
…llm-project#6112) Signed-off-by: LeiWang1999 <[email protected]>
This change adds support for a new quantization class that has the
ability to load ModelOpt checkpoints through HF. It can be invoked via -
llm = LLM(model=model_path, quantization="modelopt")
The checkpoint needs a hf_quant_config.json for loading the right
quantiztion format.
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!