Skip to content

Conversation

@cyrusd98
Copy link

Summary: No functional changes

Test Plan: CI Passes

Differential Revision: D86799190

Summary: No functional changes

Test Plan: CI Passes

Differential Revision: D86799190
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the naming of bias parameters in torch_experts and torch_moe functions within tests/kernels/utils.py. The parameters b_bias1 and b_bias2 have been renamed to w1_bias and w2_bias respectively. This change improves clarity and consistency, as the new names better reflect their association with the weight tensors w1 and w2. The refactoring has been applied correctly and consistently throughout the file, enhancing code readability and maintainability. The changes are sound and I see no issues.

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea looks good to me, what is the "Add bias tests for GPT OSS" you mentioned in the title?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants