[Bugfix] Fix qwen3 vl dummy data generation with overrides

[ywang96]

Purpose

Fix regression from #25631

FIXES #26190

Test Plan

Test Result

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
• (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

[gemini-code-assist]

Code Review

This pull request fixes a regression in dummy data generation for Qwen3-VL models with overrides. The changes correctly apply video overrides for number of frames, width, and height. My review focuses on improving code maintainability by addressing code duplication and an unused parameter. I've suggested refactoring the override logic to be more centralized and adding clarification for an unused parameter to prevent future confusion.

[wwl2755]

LGTM! nit: How about changing to make them in a consistent format like in

vllm/vllm/model_executor/models/glm4_1v.py

Lines 1143 to 1173 in 0879736

	def _get_dummy_videos(
	self,
	*,
	width: int,
	height: int,
	num_frames: int,
	num_videos: int,
	overrides: Optional[VideoDummyOptions] = None,
	) -> list[VideoItem]:
	if overrides:
	if overrides.num_frames:
	if overrides.num_frames > num_frames:
	logger.warning(
	"video.num_frames override (%d) exceeds model's "
	"maximum number of frames (%d), will be ignored",
	overrides.num_frames, num_frames)
	num_frames = min(num_frames, overrides.num_frames)
	if overrides.width:
	if overrides.width > width:
	logger.warning(
	"video.width override (%d) exceeds model's "
	"maximum width (%d), will be ignored", overrides.width,
	width)
	width = min(width, overrides.width)
	if overrides.height:
	if overrides.height > height:
	logger.warning(
	"video.height override (%d) exceeds model's "
	"maximum height (%d), will be ignored",
	overrides.height, height)
	height = min(height, override.height)

[ywang96]

LGTM! nit: How about changing to make them in a consistent format like in

vllm/vllm/model_executor/models/glm4_1v.py

Lines 1143 to 1173 in 0879736

	def _get_dummy_videos(
	self,
	*,
	width: int,
	height: int,
	num_frames: int,
	num_videos: int,
	overrides: Optional[VideoDummyOptions] = None,
	) -> list[VideoItem]:
	if overrides:
	if overrides.num_frames:
	if overrides.num_frames > num_frames:
	logger.warning(
	"video.num_frames override (%d) exceeds model's "
	"maximum number of frames (%d), will be ignored",
	overrides.num_frames, num_frames)
	num_frames = min(num_frames, overrides.num_frames)
	if overrides.width:
	if overrides.width > width:
	logger.warning(
	"video.width override (%d) exceeds model's "
	"maximum width (%d), will be ignored", overrides.width,
	width)
	width = min(width, overrides.width)
	if overrides.height:
	if overrides.height > height:
	logger.warning(
	"video.height override (%d) exceeds model's "
	"maximum height (%d), will be ignored",
	overrides.height, height)
	height = min(height, override.height)

This is unfortunately not doable for this model. For other models, typically max frames & height & size are constant, but for Qwen3-VL, max height & width needs to depend on how many frames there are, which is why this particular check needs to happen inside get_dummy_data instead of _get_dummy_video.

[wwl2755]

This is unfortunately not doable for this model. For other models, typically max frames & height & size are constant, but for Qwen3-VL, max height & width needs to depend on how many frames there are, which is why this particular check needs to happen inside get_dummy_data instead of _get_dummy_video.

Make sense. Thanks for the explaination!

[mgoin]

LGTM, just a typing nit