Skip to content

[V0 Deprecation][Models] Remove all V0 condition for mm embeddings merge #25331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[V0 Deprecation][Models] Remove all V0 condition for mm embeddings merge #25331

wants to merge 2 commits into from
+0 −657

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Sep 21, 2025 •
edited by github-actions bot
Loading

Purpose

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@Isotr0py
cleanup
eabf9b6 
Signed-off-by: Isotr0py <[email protected]>
@mergify mergify bot added the qwen Related to Qwen models label Sep 21, 2025
@Isotr0py
remove
90db524 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py marked this pull request as ready for review September 21, 2025 04:42
@mergify mergify bot added deepseek Related to DeepSeek models llama Related to Llama models labels Sep 21, 2025
@DarkLight1337
Copy link
Member

Let's wait until #16229 is merged first

@WoosukKwon
Copy link
Collaborator

Thanks for doing this!

@hmellor hmellor moved this to In Progress in V0 Deprecation Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten patrickvonplaten is a code owner

@sighingnow sighingnow Awaiting requested review from sighingnow sighingnow is a code owner

@hmellor hmellor Awaiting requested review from hmellor hmellor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
deepseek Related to DeepSeek models llama Related to Llama models qwen Related to Qwen models
Projects
V0 Deprecation
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isotr0py @DarkLight1337 @WoosukKwon