-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Docs] [V1] [Hybrid] Add new documentation re: contributing mamba-based models #23824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] [V1] [Hybrid] Add new documentation re: contributing mamba-based models #23824
Conversation
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation to reflect the current state of Mamba model support. It adds a comprehensive guide for contributors on how to add new Mamba-based models, covering different scenarios and providing helpful code references. The v1 usage guide is also updated to reflect the latest supported models and to clarify the status of prefix caching. The documentation changes are clear, accurate, and will be very helpful for the community. The updates are consistent with the provided code context. Overall, this is a great contribution to improving the project's documentation.
Signed-off-by: Thomas Parnell <[email protected]>
Does anyone know if using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!!!! Can you also mention that MambaCacheManager
is only for v0 and don't need to add related code and other if v0
code path for new models?
Signed-off-by: Thomas Parnell <[email protected]>
Done |
Signed-off-by: Thomas Parnell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very helpful doc.
Purpose
Update documentation to reflect latest state of mamba support, and add some instructions to help people contribute new mamba-based models in the future.
cc @heheda12345
Test Plan
n/a
Test Result
n/a
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.