Fix(async): Add support for truncate_prompt_tokens in AsyncLLM #23800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneraghavan
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
|
cc : @DarkLight1337 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for truncate_prompt_tokens in AsyncLLM. The implementation in the generate method can be simplified for better readability. More importantly, the implementation in the encode method contains a critical bug where truncate_prompt_tokens is ignored if tokenization_kwargs is also provided. I have included review comments with code suggestions to address these issues.
|
@DarkLight1337 Do you think anything else needs do done on this issue ? |
DarkLight1337
approved these changes
Aug 28, 2025
|
But please fix pre-commit |
DarkLight1337
added
the
ready
auto-merge was automatically disabled
August 28, 2025 16:07
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix async mode to make use of truncate_prompt_tokens param .
Fixes #23511